Add support for Sidekiq > 6 - #15
Merged
Merged
Conversation
The only change needed was the removal of the -P argument which has been deprecated in Sidekiq 6 already and we did not use it for the god configuration. If others used the `pidfile` configuration option they have to just remove it.
Member
|
Thank you. |
bigzed
approved these changes
Sep 17, 2026
bigzed
left a comment
bigzed
left a comment
Member
There was a problem hiding this comment.
Thank you. That looks good to me.
Member
Author
|
🙇 Again added the version bump in the branch to avoid pushing to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only change needed was the removal of the -P argument which has been deprecated in Sidekiq 6 already, and we did not use it for the god configuration.
If others used the
pidfileconfiguration option they have to just remove it.